Add Acronym Support for Fuzzy Search #185

taooceros · 2020-10-18T13:20:11Z

This pull request add acronym support for fuzzysearch. Link to Acronym search (or more feature) for programs #136
This pr adds mapping from translated text to original text, allowing better highlighted text display for people using pinyin search (or potential future translation).

taooceros · 2020-10-18T13:22:55Z

I originally want to do it as the way I have done before, but then I change my mind and decide to write a straight-forward search for the acronyms and query, which will make retrieve metadata easier and support the case capital letter and space both exist.

Because it is a straightforward loop, the performance should be good.

taooceros · 2020-10-18T15:12:59Z

I think the test case need update

taooceros · 2020-10-19T03:56:13Z

If this pull request has been approved, #183 should remove the part that create acronym before the pinyin. However, in order to achieve a correct matchdata highlight, IAlphabet may need to return an extra bool value suggesting whether the string is translated, since one Chinese character will project to multiple letter in pinyin form.

taooceros · 2020-12-22T10:25:28Z

I am not sure how we should implement the data match for translated data, since the length change in translation...... should we simply don't highlight data when the string has been translated? Or return an extra string for matching data, which make it the same length as the original string.
Or create an extra class for mapping the index of translated string to original string, and create highlighted index based on that.

…performance, but seems satisfying. It requires at most n times loop (n: number of translated charater) mapping once.

taooceros · 2020-12-22T13:56:38Z

@jjw24 please take a try on the new mapping class, and it allow us to even highlight text when using full pinyin. However, it will take another loop to do the mapping every time, not sure if it will be possible to optimize it more.

jjw24 · 2020-12-22T19:57:40Z

just need some clarification:

is this acronym support for cases where 'vsc' gets 'visual studio code'?
essentially it identifies first letter of every word?
should 'vs' for 'visual studio code' match?
currently this pr even match 'v' for 'visual studio code' which is a bit excessive

taooceros · 2020-12-23T01:02:53Z

just need some clarification:

is this acronym support for cases where 'vsc' gets 'visual studio code'?

essentially it identifies first letter of every word?

should 'vs' for 'visual studio code' match?

currently this pr even match 'v' for 'visual studio code' which is a bit excessive

It matches the first letter of a word seperated from whitespace or upper letter. So vsc will match both "visual studio code" or "Visual Studio Code" or "visualStudioCode" or "VisualStudioCode".
Not sure whether we should make vs match for visual studio code. I think you are right that a small panalty should be added for unmatched after query finish, while a larger panalty has been added for unmatches before query end.

…o AcronymFuzzy

jjw24 · 2021-01-31T21:08:35Z

Just reworking scoring to be based on percentage of total acronyms so code doesn't bring up long strings. Will push up the branch for you to take a look

taooceros · 2021-02-01T00:24:45Z

Thank you!

jjw24 · 2021-02-01T06:52:03Z

Flow.Launcher.Infrastructure/StringMatcher.cs

+                if (char.IsUpper(stringToCompare[compareStringIndex]) ||
+                    char.IsNumber(stringToCompare[compareStringIndex]) ||
+                    char.IsWhiteSpace(stringToCompare[compareStringIndex]) ||
+                    spaceMet)


@taooceros what's this 'spaceMet' variable trying to solve and is this needed for translation?

I think it is used to mark character after space to be acronym even when it is lower case.

Ok cool, I thought so as well. I am thinking of using substring index = 0 to replace this, since the start of substring char is always acronym

Have we split the string to compare? I think we only split the query string.

Oh we didn't, lol ok nvm then

Alternatively then, we can go back an index to check if it is space

Yeah, that's feasible.

jjw24 · 2021-02-01T11:27:42Z

please look at the updates and let me know if good to merge in here:
https://github.com/taooceros/Flow.Launcher/pull/4/files

taooceros · 2021-02-01T11:30:55Z

please look at the updates and let me know if good to merge in here:
https://github.com/taooceros/Flow.Launcher/pull/4/files

Great! I will take a look soon.

Acronym Scoring Change

taooceros · 2021-02-02T07:15:06Z

@jjw24 any further change we need to make for this PR?

jjw24 · 2021-02-02T07:28:29Z

Let me take a final look in 2hrs

jjw24

Great work @taooceros 👍

Add Acronym Support for Fuzzy Search

c63c986

taooceros added 3 commits October 18, 2020 21:24

merge one extra condition to the switch case

e264af5

merge one extra condition to the switch case

9ad7838

Add parentheses to the condition

34dc729

taooceros marked this pull request as draft October 18, 2020 13:28

Add return statement....

468f889

taooceros marked this pull request as ready for review October 19, 2020 03:52

taooceros added 2 commits October 20, 2020 08:28

use ?. and ?? instead of if == null

4d06187

Add number support (treat number as part of acronuym)

706f30a

taooceros mentioned this pull request Nov 1, 2020

Pinyin library change #183

Merged

taooceros mentioned this pull request Nov 21, 2020

Release 1.5.0 | Plugin 1.3.0 #207

Merged

taooceros added 5 commits November 22, 2020 23:02

Merge remote-tracking branch 'upstream/dev' into AcronymFuzzy

61c9797

Update to DotNet5

1ddf83f

Change name for publish file

3607bfd

Update ModernWPF so that the app can run

e973e1d

Add the new publish profile file

4ea40ab

taooceros mentioned this pull request Dec 20, 2020

Release 1.6.0 | Plugin 1.3.1 #218

Merged

jjw24 assigned taooceros Dec 21, 2020

jjw24 added enhancement New feature or request review in progress Indicates that a review is in progress for this PR labels Dec 21, 2020

Merge remote-tracking branch 'upstream/dev' into AcronymFuzzy

e67058e

Add Mapping to original string after translation. Not sure about the …

b7a0ada

…performance, but seems satisfying. It requires at most n times loop (n: number of translated charater) mapping once.

optimize use

2c9f414

taooceros and others added 4 commits January 29, 2021 17:31

Update summary

58b717c

Merge branch 'AcronymFuzzy' of github.com:taooceros/Flow.Launcher int…

efdfd06

…o AcronymFuzzy

move control variable down for readability during debug

c395cc7

add loop to check remaining acronyms if previous matched

bb6a911

jjw24 reviewed Feb 1, 2021

View reviewed changes

jjw24 added 2 commits February 1, 2021 21:34

move acronym check to method and update scoring to percentage based

99da6f2

add tests

8fb2dad

taooceros and others added 7 commits February 1, 2021 19:57

Split name matching and desciption matching due to fuzzy change

f32cbaf

fix a using

1991824

combine condition

838d0ec

remove spacing

d9a4836

separate acronym count and check

2bdf69b

Optimize code

f9b7294

Use int instead of decimal

65a6548

taooceros added this to the 1.7.0 milestone Feb 2, 2021

Merge pull request #4 from Flow-Launcher/acronym_scoring

95325a8

Acronym Scoring Change

taooceros requested a review from jjw24 February 2, 2021 07:15

jjw24 added 2 commits February 2, 2021 20:28

update summary, comments & formatting

4331398

version bump Program plugin

2602cc0

jjw24 approved these changes Feb 2, 2021

View reviewed changes

jjw24 mentioned this pull request Feb 2, 2021

Release 1.7.0 | Plugin 1.4.0 #260

Merged

jjw24 removed the review in progress Indicates that a review is in progress for this PR label Feb 2, 2021

jjw24 merged commit 9feb266 into Flow-Launcher:dev Feb 2, 2021

taooceros deleted the AcronymFuzzy branch June 29, 2021 11:00

Uh oh!

Add Acronym Support for Fuzzy Search #185

Add Acronym Support for Fuzzy Search #185

Uh oh!

Conversation

taooceros commented Oct 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

taooceros commented Oct 18, 2020

Uh oh!

taooceros commented Oct 18, 2020

Uh oh!

taooceros commented Oct 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

taooceros commented Dec 22, 2020

Uh oh!

taooceros commented Dec 22, 2020

Uh oh!

jjw24 commented Dec 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

taooceros commented Dec 23, 2020

Uh oh!

jjw24 commented Jan 31, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

taooceros commented Feb 1, 2021

Uh oh!

jjw24 Feb 1, 2021

Choose a reason for hiding this comment

Uh oh!

taooceros Feb 1, 2021

Choose a reason for hiding this comment

Uh oh!

jjw24 Feb 1, 2021

Choose a reason for hiding this comment

Uh oh!

taooceros Feb 1, 2021

Choose a reason for hiding this comment

Uh oh!

jjw24 Feb 1, 2021

Choose a reason for hiding this comment

Uh oh!

jjw24 Feb 1, 2021

Choose a reason for hiding this comment

Uh oh!

taooceros Feb 1, 2021

Choose a reason for hiding this comment

Uh oh!

jjw24 commented Feb 1, 2021

Uh oh!

taooceros commented Feb 1, 2021

Uh oh!

taooceros commented Feb 2, 2021

Uh oh!

jjw24 commented Feb 2, 2021

Uh oh!

jjw24 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

taooceros commented Oct 18, 2020 •

edited

Loading

taooceros commented Oct 19, 2020 •

edited

Loading

jjw24 commented Dec 22, 2020 •

edited

Loading

jjw24 commented Jan 31, 2021 •

edited

Loading