Safer Updater

[taooceros]

might close #1504

Note:
I am not so sure why the autoupdater may crash flow itself...I guess it is because the Elapsed callback is triggered from the main thread, but I cannot find evidence to support it, because based on document, this happens only when SynchronizingObject is set which is not we have done.

Though, I have suppressed the error of general exception from updater, so now at least it will be safer to use the autoupdater.

[jjw24]

Done an update test to ensure working as expected?

[jjw24]

Can you please fix spelling errors 'Uodate', 'settigns'.

[github-actions]

@check-spelling-bot Report

🔴 Please review

See the 📂 files view or the 📜action log for details.

Unrecognized words (4)

autoupdater
IPublic
sessionending
Uninstaller

To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:Flow-Launcher/Flow.Launcher.git repository
on the safer_updater branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/3862695136/attempts/1'

To have the bot do this for you, reply quoting the following line:
@check-spelling-bot apply updates.

If the flagged items are 🤯 false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it,
  try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[jjw24]

Looking at this, I wonder if we need to notify users when these type of errors occur?

[taooceros]

I think we did? In the later part when silentupdate is false

[jjw24]

is this a double up of await _updater.UpdateAppAsync(API);? Doesnt it run once timer is instantiated?

[jjw24]

@taooceros have you tested updating with this change?

[taooceros]

@taooceros have you tested updating with this change?

I can't reproduce the original error,but since I only add a try catch case it should be safe.