Stop spell check on push #1760
Stop spell check on push #1760
Conversation
VictoriousRaptor
added
the
github_actions
[ci skip]
VictoriousRaptor
force-pushed
the
StopSpellCheckOnPush
branch
from
5003fd3 to
2604b01
Compare
| followup: ${{ steps.spelling.outputs.followup }} | ||
| runs-on: ubuntu-latest | ||
| if: (contains(github.event_name, 'pull_request') && github.head_ref != 'l10n_dev') || github.event_name == 'push' | ||
| if: (contains(github.event_name, 'pull_request') && github.head_ref != 'l10n_dev') |
There was a problem hiding this comment.
How does this pull request event work, would it only get triggered when a pr is created? If the case then it probably wouldn't be triggered again by subsequent pushes to the pr.
I wonder maybe a better way is to just github.head_ref != dev && github.head_ref != master, so it doesn't check pushes to dev and master branches.
There was a problem hiding this comment.
It is also triggered on synchronize event (any push to the pr head triggers it). Tested in my fork.
There was a problem hiding this comment.
simply ignoring dev or master is enough though. but if you push to a fork the check is also triggered. I want to just check in the pr.
There was a problem hiding this comment.
oh forget to comment on push at the beginning of the file
| # with: | ||
| # checkout: true | ||
| # spell_check_this: check-spelling/spell-check-this@main | ||
| # task: ${{ needs.spelling.outputs.followup }} |
There was a problem hiding this comment.
This is bot comment for push checks. Check on push is disabled so this is not needed anymore.
jjw24
added
bug
[ci skip]
Stop checking on push to avoid checking merge commits on dev branch. Commits of PRs can be checked on synchronized.