Skip to content

Conversation

@jjw24
Copy link
Member

@jjw24 jjw24 commented Dec 31, 2022

Often times when I download a new plugin, I don't know the action keyword to trigger it until I check in settings. This change allows searching for the name of the plugin via Plugin Indicator to find the action keyword.

Before:
image

After:
image

Tested:

  • Plugin name is searchable
  • Action keyword is searchable
  • Selecting the result will change to the actual action keyword
  • Autocomplete will change to the actual action keyword

@jjw24 jjw24 added the bug Something isn't working label Dec 31, 2022
@jjw24 jjw24 added this to the 1.11.1 milestone Dec 31, 2022
@jjw24 jjw24 self-assigned this Dec 31, 2022
@jjw24 jjw24 enabled auto-merge December 31, 2022 08:03
@VictoriousRaptor
Copy link
Contributor

Should we give this kind of result a low score? Or it may annoy users that knows the action keyword.

@jjw24
Copy link
Member Author

jjw24 commented Dec 31, 2022

Hmm good point. What would be an appropriate score or should I rewrite it to use the score from FuzzySearch?

@VictoriousRaptor
Copy link
Contributor

Hmm good point. What would be an appropriate score or should I rewrite it to use the score from FuzzySearch?

Not familiar with this part. I guess a score from FuzzySearch should be fine. Or is it possible to provide an option to turn name search off?

@github-actions

This comment has been minimized.

@jjw24
Copy link
Member Author

jjw24 commented Jan 1, 2023

I changed it to use score from fuzzy search so the results are aligned to the rest of plugins in flow:

image

@jjw24 jjw24 requested review from VictoriousRaptor and removed request for VictoriousRaptor January 1, 2023 03:06
@Flow-Launcher Flow-Launcher deleted a comment from github-actions bot Jan 1, 2023
@Flow-Launcher Flow-Launcher deleted a comment from github-actions bot Jan 1, 2023
@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Jan 1, 2023

@check-spelling-bot Report

🔴 Please review

See the 📂 files view or the 📜action log for details.

Unrecognized words (1)

pluginindicator

To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:Flow-Launcher/Flow.Launcher.git repository
on the fix_pluginindicator_search branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/3815450104/attempts/1'

To have the bot do this for you, reply quoting the following line:
@check-spelling-bot apply updates.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@jjw24 jjw24 merged commit 43b8cc5 into dev Jan 1, 2023
@jjw24 jjw24 deleted the fix_pluginindicator_search branch January 1, 2023 05:51
@jjw24 jjw24 modified the milestones: 1.11.1, 1.12.0 Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants