Skip to content

Fix wrong Everything service warning displayed when not available #1715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 25, 2022
Merged

Fix wrong Everything service warning displayed when not available #1715

merged 1 commit into from
Dec 25, 2022

Conversation

@jjw24
Copy link
Member

@jjw24 jjw24 commented Dec 24, 2022

Before:
image

After:
image

Tested:

  • Correct warning displayed
  • Select the warning result and install Everything

@jjw24 jjw24 added the bug Something isn't working label Dec 24, 2022
@jjw24 jjw24 added this to the 1.11.0 milestone Dec 24, 2022
@jjw24 jjw24 self-assigned this Dec 24, 2022
@jjw24 jjw24 enabled auto-merge December 24, 2022 19:06
@jjw24 jjw24 merged commit 990ae3b into dev Dec 25, 2022
@jjw24 jjw24 deleted the fix_everything_warning branch December 25, 2022 05:10
@jjw24 jjw24 mentioned this pull request Dec 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VictoriousRaptor VictoriousRaptor VictoriousRaptor approved these changes

@Garulf Garulf Awaiting requested review from Garulf

@taooceros taooceros Awaiting requested review from taooceros

Assignees

@jjw24 jjw24

Labels

bug Something isn't working

Projects

None yet

Milestone

1.11.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jjw24 @VictoriousRaptor