Skip to content

Conversation

@taooceros
Copy link
Member

Fixes #163

Fix Encoding error of "GB2312" due to .net core problem by adding the injection.

@jjw24
Copy link
Member

jjw24 commented Oct 12, 2020

Thanks for the PR, let me do some testing as well before approving.

@jjw24 jjw24 self-requested a review October 12, 2020 03:18
@jjw24 jjw24 added the enhancement New feature or request label Oct 12, 2020
@jjw24 jjw24 added bug Something isn't working and removed enhancement New feature or request labels Oct 14, 2020
@jjw24
Copy link
Member

jjw24 commented Oct 16, 2020

Able to force the same error 'GB2312' is not a supported encoding name. For information on defining a custom encoding, see the documentation for the Encoding.RegisterProvider method. (Parameter 'name') by calling Encoding.GetEncoding("gb2312") in Flow. The error is resolved with this PR change.

Calling RegisterProvider from the Encoding class will make character encoding available for Flow, in this particular case helps handle user input character string that is gb2312.

@jjw24 jjw24 merged commit b66be8c into Flow-Launcher:dev Oct 16, 2020
This was referenced Oct 16, 2020
@taooceros taooceros deleted the FixEncoding branch October 18, 2020 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Web Search Plugin] Encoding error makes unable to search

2 participants