[Dev] Use path of lnk file when launching proram #1562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Could you please create an issue if not already done so. |
Contributor
Author
Already working on it. I will push the fix later. |
Member
|
Legend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1546 changed the behavior of launching .lnk programs. It directly launches the program pointed to. It wasn't intended. Got mislead by the varaible name.) which brings an issue. Start Menu shortcut of Discord can't be launched. This is because it acutally points to
blabla\Discord\Update.exe --processStart Discord.exeand we don't parse the params. Fixed in this pr.Known issue of program plugin (not related to this pr or 1546): can't distinguish different .lnk files pointing to the same target but with different params.