Skip to content

Conversation

@onesounds
Copy link
Contributor

@onesounds onesounds commented Nov 17, 2022

What's the PR

  • There is a size problem in some languages. The size of some fixed controls has been changed flexibly.
  • I had to use the context menu while doing this work. Therefore, the template of the context menu was also modified.
  • As the context menu changed, some color issues happened, so also corrected.
  • If the version is 1.0.0, it is marked as Dev. (I think it's unnecessary now...)
  • Fix BUG: Graphical interface FL 1.10.0 (November 08) Spanish Language #1522
  • Fix listview moving issue when clicking "all program" button in Program plugin.

Check Lists

  • You should check these with Slovak / Spanish / Russian language mode.
  • with Minimun Window Width
  • The color should be displayed correctly on other context menus and flyouts.

Before

After

Before

After (Adjust wrapping)

Before (Problem with some languages)

After (Put items into one button)

Before

After (Merge with update section / add dev label)

Before

After (it should display well dark/light mode)

  • Change Hardcoded text ("press key) to string / Fix Default Color (before doesn't work with theme)

Before

After

  • it should works well with light/dark mode.
  • Icon should works with isEnabled

Before

After

@taooceros taooceros requested a review from kubalav November 17, 2022 17:30
@kubalav
Copy link
Contributor

kubalav commented Nov 17, 2022

Cutted off…
Explorer plugin:
obrázok_2022-11-17_184712496

@onesounds
Copy link
Contributor Author

onesounds commented Nov 18, 2022

Cutted off… Explorer plugin

Fixed.

@onesounds onesounds self-assigned this Nov 18, 2022
@onesounds onesounds added kind/i18n kind/ui related to UI, icons, themes, etc labels Nov 18, 2022
@VictoriousRaptor VictoriousRaptor merged commit 575fb73 into Flow-Launcher:dev Nov 18, 2022
@jjw24 jjw24 added the bug Something isn't working label Nov 18, 2022
@jjw24 jjw24 added this to the 1.10.0 milestone Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working kind/i18n kind/ui related to UI, icons, themes, etc

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

BUG: Graphical interface FL 1.10.0 (November 08) Spanish Language

4 participants