Skip to content

Conversation

@ArttuLai
Copy link
Contributor

@ArttuLai ArttuLai commented Sep 1, 2020

Adds a new icon I designed to be used as the placeholder icon when Flow can't find the real app icon. Reference to issue #84

Adds a new icon I designed to be used as the placeholder icon when Flow can't find the real app icon. Reference to issue [#84](#84)
@jjw24
Copy link
Member

jjw24 commented Sep 2, 2020

Hey @ArttuLai thanks so much for contributing. Do you think you could include all the different version of the icon from the issue in the PR as well? It would be good to have a few variations, please also include the raw files so in case we want to update it in the future.

@jjw24 jjw24 added the enhancement New feature or request label Sep 2, 2020
Add all of the icons I made and shared in Issue #84
Forgot to disable grey background before exporting.
Forgot to disable grey background before exporting.
@ArttuLai
Copy link
Contributor Author

ArttuLai commented Sep 3, 2020

OK I'm ready.

Note:
The lone image from fc4a4ea is differently sized and scaled than the other ones (=smaller), but I'll leave it as is just in case.

@jjw24
Copy link
Member

jjw24 commented Sep 3, 2020

Thanks @ArttuLai . I just made a commit to move the files to its own folder.

@jjw24 jjw24 self-requested a review September 3, 2020 19:44
@jjw24 jjw24 merged commit b040eba into Flow-Launcher:dev Sep 3, 2020
@jjw24
Copy link
Member

jjw24 commented Sep 3, 2020

Will make a PR later to utilise one of the images

@ArttuLai ArttuLai deleted the ArttuLai-new_missingappicon_icon branch September 5, 2020 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants