Skip to content

Conversation

@VictoriousRaptor
Copy link
Contributor

Implemented changes required in #930.

@VictoriousRaptor VictoriousRaptor changed the title Custom Shortcut Custom Shortcut update Oct 13, 2022
@onesounds
Copy link
Contributor

onesounds commented Oct 13, 2022

Hi, Welcome on board.

  1. I added one item and tested.
  2. try to typing {clipboard} <- error happened.
  3. Close -> Rebuild -> error in jsonstorage.cs. and stucked here.

Setting.

@VictoriousRaptor
Copy link
Contributor Author

VictoriousRaptor commented Oct 13, 2022

Hi, Welcome on board.

1. I added one item and tested.

2. try to typing {clipboard} <- error happened.

3. Close -> Rebuild -> error in jsonstorage.cs. and stucked here.

Setting.

Sorry about that. I've noticed this bug right after creating this pr. Try pull it again. It should be fixed now.

Edit: I got error when typing {clipboard} too. After disabling a plugin with keyword "{" it's fine.

@VictoriousRaptor
Copy link
Contributor Author

VictoriousRaptor commented Oct 13, 2022

current problem:

  • The design is not elegant when adding/deleting/editing shortcut
  • May trigger an exception when typing {clipboard} with a plugin using action keyword "{" (VS Code Workspace in my case)

@onesounds
Copy link
Contributor

Don't be sorry. I hope you're not stressed. I saw a lot of people who were stressed out and exhausted by the fertilization work.

Anyway, before issue is fixed. and then...

  • Edit not applied.
  • Done made error in last item.

Animation6

@taooceros
Copy link
Member

Well my original design doesn't really want user to type {clipboard} (isn't that too messy to type? But leave that as a place holder for the expansion.

@taooceros
Copy link
Member

I skim through the code and i couldn't understand how shall plugin provide dynamic shortcuts? Could you explain a little about how it really works?

@VictoriousRaptor
Copy link
Contributor Author

VictoriousRaptor commented Oct 13, 2022

I skim through the code and i couldn't understand how shall plugin provide dynamic shortcuts? Could you explain a little about how it really works?

I don't have any good idea so like you said, I leave it to the future updates. I just add a Func called 'Expand' so shortcuts can execute some code more than simple string replacement.

@VictoriousRaptor
Copy link
Contributor Author

VictoriousRaptor commented Oct 13, 2022

Don't be sorry. I hope you're not stressed. I saw a lot of people who were stressed out and exhausted by the fertilization work.

Anyway, before issue is fixed. and then...

* Edit not applied.

* Done made error in last item.

I'm working on it.

@VictoriousRaptor
Copy link
Contributor Author

Don't be sorry. I hope you're not stressed. I saw a lot of people who were stressed out and exhausted by the fertilization work.
Anyway, before issue is fixed. and then...

* Edit not applied.

* Done made error in last item.

I'm working on it.

Should be fixed now.

Copy link
Member

@taooceros taooceros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a very nice improvement! Thank you so much. I am saying we may want to use another control to display the buildin shortcut. However, if you don't want to touch the UI code, we can just fix other concern and leave all these UI works to @onesounds 😝.

@taooceros
Copy link
Member

Thanks that's pretty great! We can leave some design work to @onesounds 😝

@taooceros taooceros merged commit 2489bfa into Flow-Launcher:Shortcut Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants