Fix Quick Folder Access in Explorer plugin not triggering, incorrect search behaviour, and plus minor tweaks #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even if QuickAccessFolders results matched still continue to do fIles and folders search before returning the results. This behaviour caters situation where user has a temp location in quick folder access list but still wants to search for temp folder in other locations
jjw24
changed the title
would bring up too many results
jjw24
changed the title
jjw24
changed the title
jjw24
changed the title
otherwise will throw OleDb error.
JohnTheGr8
previously approved these changes
Sep 20, 2020
Member
JohnTheGr8
left a comment
JohnTheGr8
left a comment
There was a problem hiding this comment.
Looking good, just one minor nitpick. Apologies for not reviewing earlier, time has been limited...
move above matched Quick Folder Links because it's return type and will not run the remaining code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Quick Folder Access not triggering
Fixed behaviour to continue searching for files and folders using index search even when a match is found in Quick Folder Access list. This helps if user wants file/folder that has the same name in Quick Folder Access list but in different location
Prevent user from using global action keyword for content search
Exclude from Index Search when only '_' is typed
Fixed file extension search using '*' failing/not returning results