Skip to content

Conversation

@jjw24
Copy link
Member

@jjw24 jjw24 commented Sep 16, 2022

These are all language files for Spanish & Spanish Latin America added to the dev branch at the time of this PR, copied across for v1.9.5 release.

I purposely left out the language files in Windows Settings plugin because the changes are too drastic.

Expected:
Should not have any differences in the language files between this branch and dev branch.

Tested:
Selected both Spanish and Spanish Latin America and observed that the language has changed on each screen including plugin settings.

@jjw24 jjw24 added the release Release PR which contains the changes going into the upcoming release label Sep 16, 2022
@jjw24 jjw24 added this to the 1.9.5 milestone Sep 16, 2022
@jjw24 jjw24 requested a review from taooceros September 16, 2022 13:18
@jjw24 jjw24 self-assigned this Sep 16, 2022
@taooceros
Copy link
Member

If we want to include new tranlsation, i don't think we should leave Windows setting alone. Those change won't affect other thing a lot even if it is drastic.

@jjw24
Copy link
Member Author

jjw24 commented Sep 16, 2022

I am just playing it safe, I don't know how git will handle the differences there, this is just for a release so don't want to make it too complicated.

@taooceros
Copy link
Member

Will it be hard to merge back? I am only concerning that.

@jjw24
Copy link
Member Author

jjw24 commented Sep 16, 2022

Yes my concern as well that's why I left the plugin alone, if you take a look I think there is already a default Spanish language file for master branch called 'es-EM', which is renamed (sort of) to 'es' in Dev.

@taooceros
Copy link
Member

Yes my concern as well that's why I left the plugin alone, if you take a look I think there is already a default Spanish language file for master branch called 'es-EM', which is renamed (sort of) to 'es' in Dev.

ok let's do that in the future. Hope it won't be too hard to merge back XD.

@jjw24
Copy link
Member Author

jjw24 commented Sep 17, 2022

Shouldn't be, changes are clean so far

@jjw24 jjw24 merged commit a8a19d4 into release_1_9_5 Sep 17, 2022
@jjw24 jjw24 deleted the spanish_release_1_9_5 branch September 17, 2022 00:43
@jjw24 jjw24 mentioned this pull request Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release Release PR which contains the changes going into the upcoming release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants