Skip to content

Conversation

@onesounds
Copy link
Contributor

@onesounds onesounds commented Sep 1, 2022

#717
#1286

image
image

What's the PR?

  • Add Clock & Date (Time and Cultural info based System Setting) in query area
  • It is possible to turn on and off each. (Clock only, Date only, off all)
  • Default(when first launch) is Clock only
  • Auto Hide when typing or open History/Context menu (this feature is style trigger in xaml only)
  • Add Clock and Date Color in themes

Tests

  • The watch and date should disappear when appropriate.
  • Changing time in real time.
  • Settings shall be applied immediately.
  • It should not significantly affect the speed of the process.

Todo (need help!)

  • The clock code needs to be organized. (mainwindow.cs in now)
  • The preview should work on the theme.

ETC

  • If someone want like "DDDD HH:MM"... ?
  • I don't know how to give the option for user.
  • I currently feel that this option is unnecessary.

- Add Base Clock Style
- Hide Clock when open context menu and history
- Adjust Layout
- Add Clock/Date in Settings (data only)
@onesounds onesounds self-assigned this Sep 1, 2022
@onesounds onesounds added kind/ui related to UI, icons, themes, etc enhancement New feature or request labels Sep 1, 2022
@Garulf
Copy link
Member

Garulf commented Sep 1, 2022

Looks great!

@taooceros
Copy link
Member

Is the theme changed only because of reformatting except base.xaml?

@onesounds
Copy link
Contributor Author

onesounds commented Sep 1, 2022

Is the theme changed only because of reformatting except base.xaml?

Both had to be edited.

  • Themes : I just added colors (clock font, date font). if user want, user can margin (if theme doesn't have search image), font size, colors)
  • Base : Default color and positioning, Animation / Fade-in & out animation.

You should check the clock code!

@onesounds
Copy link
Contributor Author

image

  • Added Clock/Date Format Combo box
  • Added Clock/Date Preview (when Toggled or Changed Format)

@jjw24
Copy link
Member

jjw24 commented Oct 2, 2022

I run into high memory usage when this pr was tested along with some others not sure if it's from this pr but let me have another test.

@jjw24 jjw24 marked this pull request as draft October 9, 2022 20:37
@jjw24 jjw24 added the review in progress Indicates that a review is in progress for this PR label Oct 25, 2022
@jjw24 jjw24 marked this pull request as ready for review October 25, 2022 02:21
@jjw24
Copy link
Member

jjw24 commented Oct 25, 2022

@onesounds @taooceros merge Dev please

@taooceros taooceros requested a review from jjw24 October 27, 2022 15:59
@VictoriousRaptor VictoriousRaptor linked an issue Oct 30, 2022 that may be closed by this pull request
@jjw24 jjw24 enabled auto-merge November 1, 2022 20:48
@jjw24 jjw24 removed the review in progress Indicates that a review is in progress for this PR label Nov 1, 2022
@jjw24 jjw24 added this to the 1.10.0 milestone Nov 1, 2022
@jjw24 jjw24 merged commit 0dd25f0 into Flow-Launcher:dev Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request kind/ui related to UI, icons, themes, etc

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[Feature Request] Time in Query box

4 participants