Remove calling .ToArray() on a ConcurrentDictionary
#1040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Interesting, Thank you! I previously thought that ToArray maybe more safe because of it create a buffer, but it seems that I am wrong. |
taooceros
approved these changes
Feb 28, 2022
Contributor
Author
Actually, I am not sure either, locking would probably be safer, any operation on ConcurrentDictionary can lead to unexpected behaviour. More tests would have to be conducted to confirm that. |
Member
even locking, it will be modified else where, so no difference. I remember ConcurrentDic provides a safe version of enumeration, so remove toarray should be fine. |
Merged
jjw24
added a commit
that referenced
this pull request
Mar 3, 2022
## Bug fixes - Addresses the issue where WindowsSettings plugin results appear higher than other results #1020 - Fixed an issue where full screen mode does not disable hotkey when enabled #1037 - Fixed some potential issues when loading plugins that use shared assembly #1036 - Sorted out a race condition issue causing image loading on some results to fail #1040 - Revised ttf/otf support #935 - Resolved the issue where WebSearch plugin would crash if not connected to internet #977 - Fixed incorrect text for "New Tab" and "New Window" buttons under Settings' default browser section #951 - Fixed typos in plugin title and WindowsSettings name inside the context menu #1056
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the race condition when calling
.ToArray()on aConcurrentDictionaryin theImageCacheclass.Related issue: #1039