Add plugin: Process Killer #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This plugin is a direct port of Wox.Plugin.ProcessKiller from https://github.com/theClueless/Wox.Plugins
for consistency with other plugins
To avoid killing processes by mistake, only give the option to kill all displayed processes when they are all instances of the same executable.
to kill all processes whose file path matches with the selected result.
jjw24
requested changes
Jul 3, 2020
Member
jjw24
left a comment
jjw24
left a comment
There was a problem hiding this comment.
Could we break Main's code up, at the very minimum the code handling processes should be in a separate file/class?
Otherwise LGTM
Member
Author
I agree, I wanted to split the code but it was getting late yesterday and I left it for later. Done now, and also added a couple minor enhancements. |
JohnTheGr8
force-pushed
the
plugin_process_killer
branch
from
7fb722c to
daa112e
Compare
JohnTheGr8
added
the
plugin/port
jjw24
approved these changes
Jul 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #95, I have ported Wox.Plugin.ProcessKiller as a default plugin for the Flow Launcher.
I have also made a few minor enhancements:
kill all X processeswhen the filtered process results are not all from the same path, to avoid killing processes by mistake.I think we should find a better icon but other than that it works well...
Screenshots of how it looks in action: