WebSearch 1.3.2 - Action keywords collisions with default configurations

[NikoMuffin]

To Reproduce
Steps to reproduce the behavior:

1. Use portable version of Flow Launcher (this is optional, but helps with testing on a clean install)
2. Delete all of the default search entries like Wiki or Bing
3. Close the app completely (optional)
4. Open the app and try to add Bing back.

Note in this pic, Bing does not exist

When I tried to add Bing back (using my URL configuration), it alerted of name collision. If I used "bing" instead of "b" it allows me to save.

Windows 10 64bit LTSC

WebSearch 1.3.2.
Flow Launcher 1.7.2

Flow Launcher Error Log

** ** NOTE** ** I cleared all logs file, reproduced the error, and copied the log file. There's no mention in the log of the action collision.

[taooceros]

It seems that that's because the browser favorites plugin is holding the action keyword "b" so you are unable to set the keyword of bing search to that.

[taooceros]

@mochigithub how's going? I think using another actionkeyword will work fine.

[NikoMuffin]

@mochigithub how's going? I think using another actionkeyword will work fine.

Yes, another keyword works fine, but this is non-standard design. If an entry is deleted, it should be deleted with the action keyword associated it. Just because it was there by default doesn't mean the app should still steal/keep the keyword. Does that make sense?

What is the "browser favorites plugin"? Do you mean browser bookmarks plugin?

[NikoMuffin]

@taooceros can we changed this back to bug?
Came back to write this -- this is definitely a bug. Once the user deletes the default entry, there's no way I can find to restore the default action word--- they're lost forever! For example, I lost "b" because I deleted the Bing default and re-added after. I can't find a way to restore default entries without starting over and wiping everything.

[taooceros]

But the default actionkeyword for Bing is "bing".... If you would like to use b for bing, change the actionkeyword of the browserbookmark plugin. We don't support duplicate actionkeyword for now.

[NikoMuffin]

Ohhhhhhh @taooceros I understand what you meant now by b for bing. The plugin itself is tying itself to the search keyword.
I changed the bookmark one to br and changed bing to B.

That explains bing, but what about Wiki??

There is no other entry for wiki action keyword, yet it's still preventing me from assigning that action.

[taooceros]

Hmmm I will take a look on whether it has deleted the action keyword successfully.

[NikoMuffin]

Hmmm I will take a look on whether it has deleted the action keyword successfully.

Thank you!!! I think that's what's going on here. The keywords are not deleting successfully and are actually still hidden in the background.

[taooceros]

I didn't find a logic issue in edit and delete actionkeyword in code. I do have tried to remove the entry and readd it, and it works fine.

[taooceros]

There is one issue that can prevent you doing this is to only copy the setting from websearch plugin but without the plugin.json, which contains the actionkeyword registered information. Therefore, it will create the issue for unable to add entry. I think this is also the reason of #442. Would you please also copy the plugin.json to websearch plugin directory, or manually edit the actionkeywords property in plugin.json.

The file should lies within %localappdata%\FlowLauncher\app-1.7.2\Plugins\Flow.Launcher.Plugin.WebSearch\