Plugins Manager check connection message pops up despite manifest loaded

[jjw24]

@taooceros getting this message occasionally despite plugins manager's manifest is loaded, any idea why?

Flow.Launcher/Plugins/Flow.Launcher.Plugin.PluginsManager/Main.cs

Lines 41 to 52 in 5dd12d2

	_ = updateManifestTask.ContinueWith(t =>
	{
	if (t.IsCompletedSuccessfully)
	{
	lastUpdateTime = DateTime.Now;
	}
	else
	{
	context.API.ShowMsg("Plugin Manifest Download Fail.",
	"Please check if you can connect to github.com. " +
	"This error means you may not be able to Install and Update Plugin.", pluginManager.icoPath, false);
	}

[jjw24]

i wonder maybe if the task status is something other than t.IsCompletedSuccessfully while still successfully finished, I will add t to logging and check

[taooceros]

Yeah, I agree with you. I believe this can be solved by using Task.IsFault to invert the condition check. Let me investigate more about completesuccessfully.

[taooceros]

hmmm from my testing, I didn't see the message pop out when the manifest is loaded successfully.

[taooceros]

@jjw24 Would you please create a breaking point within the continueWith method to check t.IsCompletedSuccessfully, t.IsCompleted, and t.IsFaulted when the error message pop out unexpectly?
Or you can simply check t.Status and check which status it is in.

[jjw24]

Yeah I got it writing to log including status, will update if I hit it again, it's quite random

[taooceros]

ok, thank you!