Question: Should we allows multiple plugins uses same action keyword?

[taooceros]

Flow.Launcher/Flow.Launcher.Core/Plugin/PluginManager.cs

Lines 122 to 126 in 69a5f29

	// Plugins may have multiple ActionKeywords, eg. WebSearch
	plugin.Metadata.ActionKeywords
	.Where(x => x != Query.GlobalPluginWildcardSign)
	.ToList()
	.ForEach(x => NonGlobalPlugins[x] = plugin);

Based on this code, it seems that if action keyword conflict, only the last one will be kept.

[jjw24]

The current behaviour is warn and stop user from assigning duplicate action keywords.

Not sure how it behaves with downloaded plugin having duplicate action keywords, I think it might throw plugin loading error?

But current design is to not allow duplicates.

[taooceros]

The current behaviour is warn and stop user from assigning duplicate action keywords.

That's true.

Not sure how it behaves with downloaded plugin having duplicate action keywords, I think it might throw plugin loading error?

Not sure about that. I tried to modify the plugin.json file from plugin directory, and restart flow, but nothing happens. However, nothing in the code shows potential about plugin action keywords conflict will throw an error on loading, even though we do prevent users from assigning duplicate action keywords. Maybe we should add the check on it?

[jjw24]

What would actually happen if action keywords are duplicated in two plugins, you get two sets of results right, one from each plugin, but other than that any potential problems?

[taooceros]

What would actually happen if action keywords are duplicated in two plugins, you get two sets of results right, one from each plugin, but other than that any potential problems?

Well, I think only one of the sets of results will be displayed, because the later one registering the action keyword will overwrite the earlier one.

[jjw24]

Oh ok, I think the behaviour then would be to load and disable the external plugin and output a message to let user know why it is disabled?

Or do we just want to automatically update it to a new keyword?

[taooceros]

Maybe we can allow duplicate key, so that we put the control to users about whether they want to search those two plugin with the same duplicate key.

Or do we just want to automatically update it to a new keyword?

That seems also good, but we need to notify user when doing that.

[jjw24]

I am ok with allowing duplicate keys as long as there are no side effects