URL's in Settings don't respect default system browser and just use Google Chrome

[deefrawley]

Describe the bug/issue
Settings - Theme, Plugin and About pages. All URL's start a Google Chrome instance despite Brave Browser being my default browser.

To Reproduce
Steps to reproduce the behavior:

1. Set a browser default to something other than Chrome
2. Open Settings either from Flow or from the tray menu
3. Click on any hyperlink

Your System

Windows build number: 10.0.19042.630
Flow Launcher version: 1.4.0

[jjw24]

Hey how's it going.

I haven't looked into opening with default browser yet, but can you open brave browser by setting the path to brave's exe in the plugin?

[deefrawley]

Hi Jeremy,

I added the explicit Brave path to the URL and the Web Search plugin and restarted Flow. It still uses Chrome.

[taooceros]

I think the browser used to open the link in setting windows won't link to the browser path in web search plugin and url. I think Jeremy has misunderstood your question.
I have taken a look on the implementation of the hyperlink, and the default is chrome.

Flow.Launcher/Flow.Launcher.Plugin/SharedCommands/SearchWeb.cs

Lines 14 to 20 in 98630d1

	public static void NewBrowserWindow(this string url, string browserPath = "")
	{
	var browserExecutableName = browserPath?
	.Split(new[] { Path.DirectorySeparatorChar }, StringSplitOptions.None)
	.Last();
	var browser = string.IsNullOrEmpty(browserExecutableName) ? "chrome" : browserPath;

Let me check if it is possible to change that to the default browser.
But weird that in my computer it start the link on my default browser, which is not chrome.

[deefrawley]

Thanks @taooceros. I did temporarily switch my default browser to Edge and restarted Flow to try that (and make sure it wasn't something specific to Brave) but it still used Chrome. I could try uninstalling Chrome altogether to see what happens if that would help?

[taooceros]

I found out that why in my computer it works, because I don't have chrome installed😅. If that is not too troublesome for you, you can try that. However, let me take a try to find out the way to use default browsers to open url if no specific browser path has provided. I think using chrome as default is not working as intended.

[taooceros]

Flow.Launcher.Plugin.zip
@deefrawley I am not sure whether it is possible to take the change via changing one specific dll, but take a try to replace the dll with the one in the zip. For now, the behavior should open the default browser in a new window.

[deefrawley]

Yes, that new DLL worked thanks.