BUG: Calculator does not use system locale for decimal separator

[guntern]

Checks

• I have checked that this issue has not already been reported.

Problem Description

For the calculator I use the setting for "Decimal Separator" to be "Use system locale". In my Windows settings this is set to ",". However, the calculator uses "." as decimal separator. Only when explicitly setting to "Comma (,)" it uses a ",". Normally I could work around it. But it gets really annoying when trying to copy the result to Excel, which then thinks it got provided with a date rather than a number.

To Reproduce

1. Check that Calculator plugin settings are set to "Use system locale"
2. In Windows settings the decimal separator should be set to ","
3. Try to do calculations in flow launcher with decimal numbers. Only numbers entered with "." are recognized and results are presented with "." rather than ",".

Screenshots

No response

Flow Launcher Version

1.13.0

Windows Build Number

10.0.19045.2486

Error Log

No response

[z1nc0r3]

Hi
I have tested this feature and can confirm that it is working correctly. Please restart the FL using Restart Flow Launcher command after you set the comma(,) as the Decimal symbol in Windows settings.

[guntern]

That is weird. My setting in Windows has always been set to comma. It was working until a recent update of Flow Launcher. And then it stopped working. So I restarted flow launcher quite often already (system restarts as well as restarts for plugin installation)

I did a new test:

1. set Windows settings to dot (.)
2. restart flow launcher --> still accepting dot as decimal separator
3. set Windows settings back to comma (,)
4. restart flow launcher --> still only accepting dot as decimal separator
5. double checking that in the calculator settings system locale is chosen

[github-actions]

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[guntern]

Hi,
I would like to check how the status of this issue is? Is there anything I could test to help solve it?
Best regards,

[VictoriousRaptor]

Please update to the latest version and check if this issue remains after restarting Flow. I cannot reproduce this issue.

[guntern]

I checked the updates and I am at the newest version. And the issue still remains. It is actually the same on two machines of mine. So I am really wondering, what the difference between my setup and yours is.

I will try something else, once I have more time again: I will look into the code myself. Could you point me to the section of code, which reads the system locale setting and which sets the symbol used within flow launcher depending on the setting chosen (in the plugin settings as well as the system settings)?
Thank you very much.

[taooceros]

Check the folder Plugins and inside it you can see a folder called flow.plugin.calculator and Main.cs inside that.

[VictoriousRaptor]

Plugins/Flow.Launcher.Plugin.Calculator/Main.cs

BTW have you tried resetting the settings of calculator plugin by deleting its settings.json?