BUG: FL 1.10.0 (10.10.2022) Incorrect icon

[dracp]

In the action sheet with files, the "Delete File" icon is not correct.
The folder icon should change to a file icon.

[jjw24]

Thanks @dracp, do you have a link to the proposed icon image?

[dracp]

Thanks @dracp, do you have a link to the proposed icon image?

I have directly made a composition by copying and pasting the icons from the graphic interface of the program.
If you send me the original icons of the folder with the circle and the file, I have no problem to generate the proposed icon.

[jjw24]

@onesounds thoughts?

[onesounds]

I'll change the icon to recycle bin.

+) The menu operates with the same title and icon regardless of the file or folder, so if we change it to a file icon, the opposite issue is possible. ("It's a folder, but why it's marked with a file icon?")

[dracp]

I insist
If you send me the original icons of the folder with the circle and the file, I have no problem to generate the proposed icon.

[onesounds]

Icon making is not problem. I'm not bothered by this work. The original can be found in this repo.

1. Although those two items appear to be separated, icon items are used in common on the code. I don't know who made this code, but it's not a bug and it's an intended implementation.

2. I can modify the code. but The problem is that this item is currently a code under full revision in Merge Explorer & Everything Plugins #1097, so even if it is modified here, it needs to be corrected from the beginning again.

3. I think the design of this item should be changed to a trash can without distinguishing it. (Same is the copy item. it don't need to two icon.) This is because it is usually designed that way in the context menu. Other apps do not display deletion functions separately according to folders or files. I think existing method is wrong because the delete mark is not emphasized.

I think your problem is right, but I disagree with the direction of correction.
Anyway, I don't want to give you the impression of being hard on. I think it doesn't matter if it changes because I didn't pay attention to this item. I'll do what you want.

[dracp]

I have no particular interest. It is your program. Do what you consider.
Greetings

[jjw24]

Hey, I may have had a hand in misusing the icon due to an oversight or just lazy (likely lazy 😛 ) , so thank you @dracp for picking up this bug, great attention to detail. I think what @onesounds is suggesting is have one icon that works for both scenarios (delete file and delete folder), same way Microsoft is doing for its delete icon. This will also make the code a little bit easier so we don't need to differentiate what icon to show based whether it's a file or folder that is being deleted, so let's just use a single icon instead.