-
-
Notifications
You must be signed in to change notification settings - Fork 0
Init & Improve #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThe changes update various project and solution configuration files. Two project files used for analyzers and source generators have XML reformatting (indentation adjusted from four to two spaces) without altering functional content. An old solution file was removed and replaced with a new solution file that now references three projects, including a newly introduced localization project. Additionally, the rollForward property in the global configuration was updated from "latestMinor" to "latestMajor". Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant Sln as New Solution (slnx)
participant Analyzers as Analyzers Project
participant SourceGen as SourceGenerators Project
participant Local as Localization Project
participant Build as Build System (SDK)
Dev->>Sln: Open solution file
Sln->>Analyzers: Load analyzers project
Sln->>SourceGen: Load source generators project
Sln->>Local: Load new localization project
Build->>Analyzers: Build analyzers
Build->>SourceGen: Build source generators
Build->>Local: Build localization project
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
I'm hoping to combine the two projects for later GH Action and Nuget releases, what do you think? |
|
Combine as in release both projects as a single package on Nuget? That's what I had in mind from the start. |
Yes, I get this idea from your comments in previous PR. |
Let target sdk to forward on major version: 9.0.200 works fine on my device
Move to slnx solution
Combine projects to help us test GH actions