Skip to content

Conversation

@taooceros
Copy link
Member

@taooceros taooceros commented Aug 6, 2021

We have changed the way of debugging in Flow, so also need to change the jsonrpc package.

By the way, why do we need the demjson?

@Garulf
Copy link
Member

Garulf commented Oct 31, 2021

We have changed the way of debugging in Flow, so also need to change the jsonrpc package.

By the way, why do we need the demjson?

I'm not entirely sure to be honest, It's being used the same as the bulit-in JSON library. It has some added functionality for linting but thats not being used as far as I can tell.

@Zeroto521
Copy link
Member

Zeroto521 commented Oct 31, 2021

json in standard lib can't parser some string to dict data structure, and this will raise a error.

@taooceros
Copy link
Member Author

json in standard lib can't parser some string to dict data structure, and this will raise a error.

Could you gives an example? I think flow's json will be generally standard json because it is created by .net json library (which is type based).

@Zeroto521
Copy link
Member

@taooceros detail see aa145ff git comment message

@taooceros
Copy link
Member Author

@taooceros detail see aa145ff git comment message

I think it wouldn't be a issue now because we stop using a customized json parser now. We use standard .net json library so it should produce standard json.

@Garulf
Copy link
Member

Garulf commented Nov 4, 2021

I don't see any issues other then the string assignment and that was fixed.

@Garulf Garulf merged commit 89f6ca6 into master Nov 16, 2021
@jjw24 jjw24 deleted the DebugFix branch November 17, 2021 02:56
@jjw24 jjw24 added the bug Something isn't working label Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants