Improvement #8161 : Cardinality estimation should use primary record versions only #8162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do I understand right that your code counts records on only one data page because |
Almost correct
No, read it again |
dyemanov
reviewed
Jun 18, 2024
src/jrd/dpm.epp
Outdated
| @@ -245,47 +245,52 @@ double DPM_cardinality(thread_db* tdbb, jrd_rel* relation, const Format* format) | |||
|
|
|||
| ULONG recordCount = 0, recordLength = 0; | |||
|
|
|||
| const RelationPages* const relPages = relation->getPages(tdbb); | |||
| RelationPages* const relPages = relation->getPages(tdbb); | |||
| const vcl* const vector = relPages->rel_pages; | |||
| if (vector) | |||
There was a problem hiding this comment.
It looks like vector is not used anymore, so maybe just if (relPages->rel_pages) ?
Not sure this check is needed at all, BTW.
There was a problem hiding this comment.
Done with vector, as for the check - it makes no harm.
dyemanov
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.