Improvement #7928 : Make TempCacheLimit setting to be per-database, (not per-attachment) for SuperClassic. #7930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not per-attachment) for SuperClassic.
asfernandes
reviewed
Dec 19, 2023
src/jrd/Database.cpp
Outdated
| return false; | ||
|
|
||
| const auto old = m_tempCacheUsage.fetch_add(size); | ||
| if (old + size > limit) |
There was a problem hiding this comment.
Isn't it problematic that someone trying to increase a size and not aquiring it, may temporary avoid that others increase they usage to values that otherwise would be valid?
There was a problem hiding this comment.
Yes, it is possible but I doesn't consider it as a problem.
If someone can't allocate the memory, it means the process have a much more serious issue currently.
…methods also. Cache value of TempCacheLimit setting at global holder, as Dmitry suggests
dyemanov
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.