Skip to content

Rename RSA_SIGN and RSA_VERIFY #6806

@AlexPeshkoff

Description

@AlexPeshkoff

The RSA_SIGN and RSA_VERIFY functions are potentially confusing, as they don't actually do what - I think - most users would expect: sign a message of arbitrary length.

Their actual use is to sign a hash of a message, with the additional constraint that the HASH parameter of the function needs to be supplied with the hash algorithm that was used to generate that hash.

Given this confusing use case, I suggest that we rename RSA_SIGN to RSA_SIGN_HASH, and RSA_VERIFY to RSA_VERIFY_HASH, and clarify the release notes further.

The advantage of this is that the name makes clear - I hope - it signs a hash, and that we could - at a later time - add a function that signs/verifies a message of arbitrary length (e.g. RSA_SIGN/RSA_VERIFY or - maybe better - RSA_SIGN_MESSAGE/RSA_VERIFY_MESSAGE).

I know this is very late, but I think this is better to do this before releasing Firebird 4 than the alternative of having to live with an unclear function for all eternity.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions