Fix build #2
Closed
Fix build #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In file included from ../../IscDbc/IscDatabaseMetaData.cpp:47:
../../IscDbc/IscDatabaseMetaData.cpp: In member function ‘virtual const char* IscDbcLibrary::IscDatabaseMetaData::getDriverVersion()’:
../../IscDbc/../SetupAttributes.h:139:65: error: inconsistent user-defined literal suffixes ‘minor’ and ‘buildnum’ in string literal
#define BUILD_DRIVER_VERSION(major,minor,buildnum) major"."minor"."buildnum
^~~~~~~~~~~
../../IscDbc/../SetupAttributes.h:150:25: note: in expansion of macro ‘BUILD_DRIVER_VERSION’
#define DRIVER_VERSION BUILD_DRIVER_VERSION( ZERO_MAJOR BUILD_STR2( MAJOR_VERSION ), ZERO_MINOR BUILD_STR2( MINOR_VERSION ), ZERO_BUILDNUM BUILD_STR2( BUILDNUM_VERSION ) )
^~~~~~~~~~~~~~~~~~~~
../../IscDbc/IscDatabaseMetaData.cpp:350:9: note: in expansion of macro ‘DRIVER_VERSION’
return DRIVER_VERSION;
^~~~~~~~~~~~~~
../../IscDbc/../SetupAttributes.h:139:65: error: unable to find string literal operator ‘operator""minor’ with ‘const char [5]’, ‘long unsigned int’ arguments
#define BUILD_DRIVER_VERSION(major,minor,buildnum) major"."minor"."buildnum
^~~~~~~~~~~
../../IscDbc/../SetupAttributes.h:150:25: note: in expansion of macro ‘BUILD_DRIVER_VERSION’
#define DRIVER_VERSION BUILD_DRIVER_VERSION( ZERO_MAJOR BUILD_STR2( MAJOR_VERSION ), ZERO_MINOR BUILD_STR2( MINOR_VERSION ), ZERO_BUILDNUM BUILD_STR2( BUILDNUM_VERSION ) )
^~~~~~~~~~~~~~~~~~~~
../../IscDbc/IscDatabaseMetaData.cpp:350:9: note: in expansion of macro ‘DRIVER_VERSION’
return DRIVER_VERSION;
^~~~~~~~~~~~~~
|
Seriously, why isnt this merged? |
|
@AsToNlele Unfortunately, the maintainer of the firebird-odbc-driver hasn't been active lately. Until he returns, or another maintainer steps up, this project is pretty much on hold. |
|
I can confirm that this allowed the driver to build for me in gcc 9.3.0 on Ubuntu 20.04 (after some fiddling with FBLIBDIR to point it at Since this is under the purview of the FirebirdSQL organization, shouldn't someone from that be able to merge this change? |
irodushka
added a commit
that referenced
this pull request
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In file included from ../../IscDbc/IscDatabaseMetaData.cpp:47:
../../IscDbc/IscDatabaseMetaData.cpp: In member function ‘virtual const char* IscDbcLibrary::IscDatabaseMetaData::getDriverVersion()’:
../../IscDbc/../SetupAttributes.h:139:65: error: inconsistent user-defined literal suffixes ‘minor’ and ‘buildnum’ in string literal
#define BUILD_DRIVER_VERSION(major,minor,buildnum) major"."minor"."buildnum
^~~~~~~~~~~
../../IscDbc/../SetupAttributes.h:150:25: note: in expansion of macro ‘BUILD_DRIVER_VERSION’
#define DRIVER_VERSION BUILD_DRIVER_VERSION( ZERO_MAJOR BUILD_STR2( MAJOR_VERSION ), ZERO_MINOR BUILD_STR2( MINOR_VERSION ), ZERO_BUILDNUM BUILD_STR2( BUILDNUM_VERSION ) )
^~~~~~~~~~~~~~~~~~~~
../../IscDbc/IscDatabaseMetaData.cpp:350:9: note: in expansion of macro ‘DRIVER_VERSION’
return DRIVER_VERSION;
^~~~~~~~~~~~~~
../../IscDbc/../SetupAttributes.h:139:65: error: unable to find string literal operator ‘operator""minor’ with ‘const char [5]’, ‘long unsigned int’ arguments
#define BUILD_DRIVER_VERSION(major,minor,buildnum) major"."minor"."buildnum
^~~~~~~~~~~
../../IscDbc/../SetupAttributes.h:150:25: note: in expansion of macro ‘BUILD_DRIVER_VERSION’
#define DRIVER_VERSION BUILD_DRIVER_VERSION( ZERO_MAJOR BUILD_STR2( MAJOR_VERSION ), ZERO_MINOR BUILD_STR2( MINOR_VERSION ), ZERO_BUILDNUM BUILD_STR2( BUILDNUM_VERSION ) )
^~~~~~~~~~~~~~~~~~~~
../../IscDbc/IscDatabaseMetaData.cpp:350:9: note: in expansion of macro ‘DRIVER_VERSION’
return DRIVER_VERSION;
^~~~~~~~~~~~~~