There are cases where `isRequired` specifications are not properly merged.

[k163377]

Jackson has a policy of merging annotations assigned to accessors, fields, or parameters into a single property.
ProjectMapK/jackson-module-kogera#101 (comment)

Therefore, the goal of this issue is to match the behavior of databind.

The following is an old explanation.

---

Describe the bug
For example, if a getter is given JsonProperty(required = true), the parameter nullability is ignored and overridden by required = true.
This appears to be an unexpected behavior, since getters are not involved in deserialization.

Also, since this override does not occur for setters, there is no consistency in behavior.

To Reproduce

import com.fasterxml.jackson.annotation.JsonProperty
import com.fasterxml.jackson.databind.BeanDescription
import com.fasterxml.jackson.databind.ObjectMapper
import com.fasterxml.jackson.module.kotlin.jacksonObjectMapper
import org.junit.Test

class PropRequiredTest {
    val mapper = jacksonObjectMapper()

    private inline fun <reified T> ObjectMapper.introspectDeser(): BeanDescription =
        deserializationConfig.introspect(deserializationConfig.constructType(T::class.java))

    private fun BeanDescription.isRequired(propertyName: String): Boolean =
        this.findProperties().find { it.name == propertyName }?.isRequired ?: false

    data class AffectByAccessor(
        @get:JsonProperty(required = true)
        var a: String?,
        @field:JsonProperty(required = true)
        var b: String?,
        @set:JsonProperty(required = true)
        var c: String?
    ) {
        @get:JsonProperty(required = true)
        var x: String? = null
        @field:JsonProperty(required = true)
        var y: String? = null
        @JvmField
        @field:JsonProperty(required = true)
        var z: String? = null
    }

    @Test
    fun affectByAccessorTestDeser() {
        val desc = mapper.introspectDeser<AffectByAccessor>()

        // The expected value of a ~ c is false, but the actual values are all true.
        val a = desc.isRequired("a")
        val b = desc.isRequired("b")
        val c = desc.isRequired("c")

        // x and y is false and z is true. These are the expected values.
        val x = desc.isRequired("x")
        val y = desc.isRequired("y")
        val z = desc.isRequired("z")
    }
}

Expected behavior
Annotations assigned to accessors should not affect the creator.

Versions
Kotlin: 1.5.32
Jackson-module-kotlin & Jackson-databind: 2.15.0

Additional context
If processing is performed without registering a KotlinModule, a ~ c and x ~ z will all be true.
Therefore, a possible policy is to match the KotlinModule to this result.

[k163377]

@cowtowncoder
Can you please confirm this as I think it has something to do with databind as well?
Personally, I think there should be a strict distinction between serialization and deserialization contexts.

[cowtowncoder]

@k163377 Yes and no: annotations are merged across accessors on purpose, to remove need to duplicate settings (i.e. can add @JsonProperty("name") on just getter, to affect both serialization and deserialization). But precedence does vary between ser/deser, so overrides should work as expected (getter overrides field for serialization, but setter would override getter, etc).

One problem, however, is that information from annotations is not merged as part of flattening: so all information from @JsonProperty comes from one specific annotation instance; it is not possible to override just one aspect. So required being part of @JsonProperty, settings comes from highest-precedence annotation, regardless of whether it explicitly defines it or not.

[k163377]

@cowtowncoder
Thanks for the answer.
I have updated the description as it seems more correct to match the behavior of databind.

[k163377]

Due to the change regarding #941(#952), the behavior of explicitly specifying required in 3.x is now the same as for databind.
This issue is closed with the addition of a test case.