Fix #598: Separate END_OBJECT return from parser close in ProtobufParser #626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, ProtobufParser would call close() while simultaneously returning END_OBJECT at the top level, causing the parser to be in a closed state immediately after returning the final token. This created incompatibility with jackson-core issue #1438. Solution: - Added new parser state STATE_ROOT_END to separate the two actions - Parser now returns END_OBJECT in STATE_ROOT_END state - Parser only closes on the subsequent nextToken() call - Updated all methods: nextToken(), nextName(), nextName(SerializableString), nextNameMatch(), and _skipUnknownField() - Clear current name when transitioning to STATE_ROOT_END Also added CLAUDE.md documentation file for AI assistants working with this codebase. Tests: - Added ParserStateEndTest with 3 test methods verifying correct behavior - All 98 protobuf tests pass with no regressions
cowtowncoder
added
the
gen-ai
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #598: Separate END_OBJECT return from parser close in ProtobufParser
Previously, ProtobufParser would call close() while simultaneously returning END_OBJECT at the top level, causing the parser to be in a closed state immediately after returning the final token. This created incompatibility with jackson-core issue #1438.
Solution:
- Added new parser state STATE_ROOT_END to separate the two actions
- Parser now returns END_OBJECT in STATE_ROOT_END state
- Parser only closes on the subsequent nextToken() call
- Updated all methods: nextToken(), nextName(), nextName(SerializableString),
nextNameMatch(), and _skipUnknownField()
- Clear current name when transitioning to STATE_ROOT_END
NOTE: PR created on Claude Code proposed fix.