Skip to content

(EXPERIMENTAL) Fix #624: try to use more efficient String constructor #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: 3.x
Choose a base branch
from
Draft

(EXPERIMENTAL) Fix #624: try to use more efficient String constructor #625

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34b9070
Fix #624: try to use more efficient String constructor
cowtowncoder Oct 26, 2025
2c4a341
Merge branch '3.x' into tatu/3.1/624-cbor-new-string
cowtowncoder Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions cbor/src/main/java/tools/jackson/dataformat/cbor/CBORParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2434,8 +2434,11 @@ private final String _finishShortText(int len) throws JacksonException
i = inputBuf[inPtr++];
outBuf[outPtr++] = (char) i;
}
if (inPtr == end && i >= 0) {
String str = _textBuffer.setCurrentAndReturn(outPtr);
if (inPtr == end && i >= 0) { // all ASCII
// 25-Oct-2025: [dataformats-binary#624] Minor optimization: can directly
// construct String; faster in JDK 17+
//String str = _textBuffer.setCurrentAndReturn(outPtr);
String str = _textBuffer.resetWithASCII(inputBuf, inPtr-len, len);
if (stringRefs != null) {
stringRefs.stringRefs.add(str);
_sharedString = str;
Expand Down