Skip to content

Conversation

stevenschlansker
Copy link
Contributor

@stevenschlansker stevenschlansker commented Apr 11, 2025

Currently the case is mis-matched which accidentally relies on final field setting.
Instead, just fix the annotations so the case matches and the constructor
is properly used

@cowtowncoder
Copy link
Member

I think use of final here may be an oversight: would it be possible to instead remove final markers to test regular Builder pattern for XML module?
(unless there are already similar tests)

Currently the case is mis-matched which relies on `final` field setting.
Instead, just fix the annotations so the case matches and the constructor
is properly used
@stevenschlansker stevenschlansker changed the title Remove test for #291 Update test for #291 Apr 11, 2025
@stevenschlansker
Copy link
Contributor Author

Ok, does this look better?

@cowtowncoder
Copy link
Member

@stevenschlansker Yes, thank you! I think I'll backport this in 2.19 as well.

@cowtowncoder cowtowncoder merged commit c6c43e0 into FasterXML:3.x Apr 11, 2025
3 checks passed
cowtowncoder added a commit that referenced this pull request Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants