Update test for #291 #744
Merged
Update test for #291 #744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think use of |
Currently the case is mis-matched which relies on `final` field setting. Instead, just fix the annotations so the case matches and the constructor is properly used
stevenschlansker
force-pushed
the
remove-291-test
branch
from
59000b7 to
74fa1f1
Compare
|
Ok, does this look better? |
|
@stevenschlansker Yes, thank you! I think I'll backport this in 2.19 as well. |
cowtowncoder
added a commit
that referenced
this pull request
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the case is mis-matched which accidentally relies on
finalfield setting.Instead, just fix the annotations so the case matches and the constructor
is properly used