Skip to content

Conversation

@cowtowncoder
Copy link
Member

No description provided.

@cowtowncoder
Copy link
Member Author

Not sure this is going anywhere, bumping into issue of #4634, among other problems.

@cowtowncoder cowtowncoder marked this pull request as ready for review July 25, 2024 02:09
@cowtowncoder
Copy link
Member Author

Think I might have solved the problems by only removing Record Fields:

  1. After annotations merged AND
  2. Only for deserialization (where we shouldn't change value)

@cowtowncoder
Copy link
Member Author

@yihtserns WDYT? Looks like this change works, with your earlier fix.

@yihtserns
Copy link
Contributor

yihtserns commented Jul 25, 2024

@cowtowncoder Why still drop the fields, though? To avoid any other unexpected side-effects?

@yihtserns
Copy link
Contributor

yihtserns commented Jul 25, 2024

Oh right, dropping fields to avoid SettableBeanProperty (specifically FieldProperty) from being created for them. OK.

Yeah I guess this is a good alternative to #4627.

@cowtowncoder
Copy link
Member Author

Oh right, dropping fields to avoid SettableBeanProperty (specifically FieldProperty) from being created for them. OK.

Yeah I guess this is a good alternative to #4627.

Correct, so Field is never used as mutator for Records (it fixes one specific test).

@cowtowncoder cowtowncoder merged commit aafba87 into 2.18 Jul 25, 2024
@cowtowncoder cowtowncoder deleted the tatu/2.18/4626-record-with-ignore branch July 25, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants