Improve JavaDoc and add tests for DeserializationFeature.FAIL_ON_UNRESOLVED_OBJECT_IDS
#3880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JooHyukKim
changed the title
DeserializationFeature.FAIL_ON_UNRESOLVED_OBJECT_IDSDeserializationFeature.FAIL_ON_UNRESOLVED_OBJECT_IDS
JooHyukKim
commented
Apr 13, 2023
| .readValue(a2q("{'node':123}")); | ||
| assertNotNull(w2); | ||
| assertNull(w2.node); | ||
| } |
Member
Author
There was a problem hiding this comment.
Shouldn't this test result the same , like below test testUnresolvableConfigureFeatureSymmetry()? 🤔
Hopefully, I am mistaken and there is no bug.
You can also refer to another already-existing test in the same class.
cowtowncoder
approved these changes
Apr 22, 2023
| private final ObjectMapper DEFAULT_MAPPER = newJsonMapper(); | ||
|
|
||
| private final ObjectMapper DISABLED_MAPPER = newJsonMapper() | ||
| .configure(DeserializationFeature.FAIL_ON_UNRESOLVED_OBJECT_IDS, false); |
Member
There was a problem hiding this comment.
Going forward let's try to use JsonMapper.builder() so code will merge and work with 3.0. I will change this after merging.
cowtowncoder
added a commit
that referenced
this pull request
Apr 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DeserializationFeature.FAIL_ON_UNRESOLVED_OBJECT_IDS