Explicitly change PatternDrawState visibility to public #957
Conversation
|
What is the purpose of this change? Also, |
This would allow someone to not have to work around the access barrier in order to get the user's drawing state, as right now loads of reflection has to be done to obtain this.
For me, I'd like this to ease how keyboard-input hexes get implemented in my mod/addon. Thread @ https://canary.discord.com/channels/936370934292549712/936371750126645278/1431694097634037851
Odd, I remember public being required in some form or another for nested classes? |
| public object BetweenPatterns : PatternDrawState() | ||
|
|
||
| /** We just started drawing and haven't drawn the first line yet. */ | ||
| data class JustStarted(val start: HexCoord) : PatternDrawState() | ||
| public data class JustStarted(val start: HexCoord) : PatternDrawState() | ||
|
|
||
| /** We've started drawing a pattern for real. */ | ||
| data class Drawing(val start: HexCoord, var current: HexCoord, val wipPattern: HexPattern) : PatternDrawState() | ||
| public data class Drawing(val start: HexCoord, var current: HexCoord, val wipPattern: HexPattern) : PatternDrawState() |
There was a problem hiding this comment.
None of these should be necessary - just removing the private modifier on PatternDrawState (not explicitly setting anything to public) should be adequate afaik.
2 participants
No description provided.