Config option for Greater Teleport item splatting #841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forge/src/main/java/at/petrak/hexcasting/forge/ForgeHexConfig.java
Outdated
Show resolved
Hide resolved
object-Object
requested changes
Feb 3, 2025
object-Object
approved these changes
Feb 4, 2025
|
oh, it seems like there are some conflicts now |
|
do I rebase and close and reopen this PR? |
TheDrawingCoder-Gamer
force-pushed
the
config-greater-teleport
branch
from
2621137 to
0e20a38
Compare
|
a merge commit would have been better, but I guess that works |
|
you shouldn't need to close and reopen the PR. |
|
Oops, broke the commit I just applied in github, LOL |
|
I haven't tested ingame after the rebase, but I'm going to lazily merge it in anyway because I don't see why it would have broken (fingers crossed). Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds config option for whether items fly out of your inventory upon using greater teleport
closes #502