Skip to content

install: validate checksums #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

install: validate checksums #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,15 @@ optional arguments:
```

Missing components:
- Checksum verification
- Custom data installation:
- `headers`
- `data`

### Bootstraping

`install` has a dependency on `installer`, which is used for entrypoint script
generation. As we don't install entrypoint scripts, this dependency is not needed
to install a `install` wheel, making `install` bootstrapable without any
dependencies.
generation and checksum validation. As we don't install entrypoint scripts,
this dependency is not needed to install a `install` wheel, making `install`
bootstrapable without any dependencies. The only thing is that you won't get the
checksum validation, but if you are building from source that shouldn't be a
problem.
17 changes: 17 additions & 0 deletions install/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,21 @@ def _copy_dir(src, dst, ignore=[]): # type: (str, str, List[str]) -> None
shutil.copy2(path, root)


def _validate_checksums(dist_info, dir): # type: (str, str) -> None
try:
import installer.records

with open(os.path.join(dist_info, 'RECORD'), 'r') as f:
lines = [line.strip() for line in f]

for record in installer.records.parse_record_file(lines):
with open(os.path.join(dir, record.path.as_posix()), 'rb') as fr:
if not record.validate(fr.read()):
raise InstallException('Invalid checksum: {}'.format(record))
except ImportError:
warnings.warn("'installer' package missing, skipping checksum verification", RuntimeWarning)


def _generate_entrypoint_scripts(file, dir): # type: (str, str) -> None
entrypoints = configparser.ConfigParser()
entrypoints.read(file)
Expand Down Expand Up @@ -228,6 +243,8 @@ def build(wheel, cache_dir, optimize=[0, 1, 2], verify_dependencies=False): # t
elif optimize:
compileall.compile_dir(pkg_cache_dir)

_validate_checksums(dist_info, pkg_cache_dir)

if os.path.isfile(entrypoints_file):
_generate_entrypoint_scripts(entrypoints_file, scripts_cache_dir)

Expand Down