Skip to content

feat: support for expire in milliseconds #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: support for expire in milliseconds #31

wants to merge 3 commits into from

Conversation

divyanshu-in
Copy link

description

  • for fixed window rate limiting, most of the time expiry is in milliseconds, this PR replaced the "EXPIRE" with "PEXPIRE" in lua script.
  • default behaviour of expiry duration in seconds is retained.

@divyanshu-in
Copy link
Author

@italorossi can this PR be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@divyanshu-in @dichouhan