Conditional compilation of plugins #527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intjftw
added
Kind: Enhancement 🌟
Target: Developer environment
whisperity
reviewed
Apr 13, 2021
plugins/CMakeLists.txt
Outdated
Comment on lines
16
to
17
| message(WARNING "The search and metrics plugins cannot be left out, " | ||
| "they will be compiled anyway.") |
There was a problem hiding this comment.
Emphasise they are options:
Suggested change
| message(WARNING "The search and metrics plugins cannot be left out, " | |
| "they will be compiled anyway.") | |
| message(WARNING "The 'search' and 'metrics' plugins cannot be left out, " | |
| "they will be compiled anyway.") |
plugins/CMakeLists.txt
Outdated
Comment on lines
30
to
31
| message(WARNING "The search and metrics plugins cannot be left out, " | ||
| "they will be compiled anyway.") |
There was a problem hiding this comment.
Suggested change
| message(WARNING "The search and metrics plugins cannot be left out, " | |
| "they will be compiled anyway.") | |
| message(WARNING "The 'search' and 'metrics' plugins cannot be left out, " | |
| "they will be compiled anyway.") |
plugins/CMakeLists.txt
Outdated
Comment on lines
33
to
40
| foreach(_plugin ${plugins}) | ||
| if(("${_plugin}" IN_LIST WITHOUT_PLUGIN) | ||
| AND NOT ("${_plugin}" STREQUAL "metrics") | ||
| AND NOT ("${_plugin}" STREQUAL "search") | ||
| AND (IS_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/${_plugin}")) | ||
| list(REMOVE_ITEM plugins ${_plugin}) | ||
| endif() | ||
| endforeach() |
There was a problem hiding this comment.
Can we factor this loop out from the if()s? The hardcoded keeping of search and metrics and everything else is duplicated in here.
There was a problem hiding this comment.
I refactored it, however, I think it is less readable this way.
mcserep
approved these changes
Apr 16, 2021
intjftw
force-pushed
the
conditional_compilation
branch
from
15884a7 to
34765c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a
WITH_PLUGINand aWITHOUT_PLUGINoption to the cmake command. By usingWITH_PLUGIN, the user can specify the plugins they want to build. By usingWITHOUT_PLUGIN, the user can specify the plugins they don't want to build. The options cannot be used together at the same time. If neither is specified, all plugins are to be built.