Skip to content

prometheus metric config generation adjustment #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

prometheus metric config generation adjustment #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions lib/fluent/config.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
module FluentConfig
BUILTIN_PARAMETERS = ['type', 'id', 'label', 'log_level'].freeze
BUILTIN_PARAMETER_PREFIX = '@'.freeze
PREFIX_EXCEPTION_SCOPES = ['system', 'metric'].freeze
TAG_PATTERN = 'tag_pattern'.freeze
BODY_PADDING = ' '.freeze

Expand All @@ -23,7 +24,7 @@ def generate(config, header = '')
result << directive_tag(plugin_type, tag_pattern) do
plugin_config.keys.sort.reduce('') do |body, parameter|
body << directive_body(
(plugin_type == 'system' ? parameter : format_parameter(parameter)),
format_parameter(parameter, plugin_type),
plugin_config.fetch(parameter),
)
end
Expand Down Expand Up @@ -62,12 +63,10 @@ def left_pad(text, padding)
end
end

def format_parameter(parameter)
if BUILTIN_PARAMETERS.include?(parameter)
BUILTIN_PARAMETER_PREFIX + parameter
else
parameter
end
def format_parameter(parameter, scope)
return parameter if PREFIX_EXCEPTION_SCOPES.include? scope
return parameter unless BUILTIN_PARAMETERS.include? parameter
BUILTIN_PARAMETER_PREFIX + parameter
end
end
end