Fix minor issues #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

osipovartem merged 1 commit into main from fix_minors

Feb 6, 2025

Contributor

osipovartem commented Feb 6, 2025

added references check to use TableReference from datafusion
added support for Merge statement warehouse check
removed overlapping logic for table_path check
fixed convert_timezone return type
moved common logic for show objects and schemas to a separate func


          Fix minor issues

13f1bdb

osipovartem requested review from DanCodedThis, Vedin, YaroslavLitvinov, eadgbear and rampage644

February 6, 2025 13:53

osipovartem commented

View reviewed changes

crates/runtime/src/datafusion/execution.rs Show resolved Hide resolved

osipovartem commented

View reviewed changes

crates/runtime/src/datafusion/execution.rs Show resolved Hide resolved

osipovartem commented

View reviewed changes

crates/runtime/src/datafusion/execution.rs Show resolved Hide resolved

osipovartem commented

View reviewed changes

crates/runtime/src/datafusion/functions/convert_timezone.rs Show resolved Hide resolved

osipovartem commented

View reviewed changes

crates/runtime/src/datafusion/planner.rs Show resolved Hide resolved

osipovartem commented

View reviewed changes

crates/runtime/src/datafusion/planner.rs Show resolved Hide resolved

DanCodedThis approved these changes

View reviewed changes

rampage644 approved these changes

View reviewed changes

osipovartem merged commit 2006f0c into main

5 checks passed

osipovartem deleted the fix_minors branch

February 6, 2025 15:26

osipovartem temporarily deployed to production

February 6, 2025 15:26

— with

GitHub Actions Inactive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet