Skip to content

Add custom type planner #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 30, 2025
Merged

Add custom type planner #171

merged 3 commits into from
Jan 30, 2025

Conversation

@osipovartem
Copy link
Contributor

@osipovartem osipovartem commented Jan 29, 2025 •
edited
Loading

Closes #131

  • it's not possible to use session with_type_planner with custom SessionContext. Since there is no type_planner() method in SessionState (should be implemented in datafusion repo).
  • Added custom type_planner to CustomContextProvider directly and removed default logic for other types

DanCodedThis
DanCodedThis previously approved these changes Jan 29, 2025
View reviewed changes
rampage644
rampage644 reviewed Jan 29, 2025
View reviewed changes
@osipovartem osipovartem merged commit 72d7f66 into main Jan 30, 2025
5 checks passed
@osipovartem osipovartem deleted the issue-131/move_datatypes branch January 30, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rampage644 rampage644 rampage644 left review comments

@Vedin Vedin Vedin approved these changes

@DanCodedThis DanCodedThis DanCodedThis approved these changes

+1 more reviewer

@eadgbear eadgbear eadgbear approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor datatypes in query planner

6 participants

@osipovartem @eadgbear @rampage644 @Vedin @DanCodedThis