Datediff func #153
Merged
Datediff func #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanCodedThis
requested review from
Vedin,
eadgbear,
osipovartem and
rampage644
osipovartem
reviewed
Jan 20, 2025
osipovartem
previously approved these changes
Jan 20, 2025
Vedin
approved these changes
Jan 20, 2025
Contributor
Vedin
left a comment
Vedin
left a comment
There was a problem hiding this comment.
lgtm. I'd suggest adding small test for this. Probably, something similar to what date_trunc or other native datetime functions have in datafusion.
Contributor
Author
|
I'll merge for now and add tests later |
DanCodedThis
temporarily deployed
to
production
GitHub Actions
Inactive
Contributor
Author
|
Can't push to prod, since github actions are out for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.