Naive convert timezone func, with some date_add bug fixes #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th curl "select dateadd('\''days'\'', 3,'\''2024-12-26'\'')"
…o the ZII pattern from Casey Muratori (MollyRocket) meaning the defaults or do we want some specific panic?
DanCodedThis
requested review from
Vedin,
eadgbear,
osipovartem and
rampage644
Contributor
Author
|
I didn't yet add the tests, but you can review the code for now |
rampage644
reviewed
Jan 15, 2025
rampage644
reviewed
Jan 15, 2025
Contributor
rampage644
left a comment
rampage644
left a comment
There was a problem hiding this comment.
I cannot review the PR on the merits, so just nitpicks and generic comments.
Please split this PR into two independent and remove unneeded code and comments.
Contributor
Author
|
@rampage644 Sure |
eadgbear
previously approved these changes
Jan 15, 2025
Contributor
Author
|
Splitting pr |
DanCodedThis
temporarily deployed
to
production
GitHub Actions
Inactive
rampage644
approved these changes
Jan 16, 2025
DanCodedThis
temporarily deployed
to
production
GitHub Actions
Inactive
This was
unlinked from
issues
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.