Replace jquery-params with URL API and authorize unamed action name #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GreatWizard
changed the title
Exelord
requested changes
Nov 23, 2018
| let pathUrl = url.charAt(url.length - 1) === '/' ? `${url}${path}` : `${url}/${path}`; | ||
|
|
||
| return query ? `${pathUrl}?${query}` : pathUrl; | ||
| let urlObj = new URL(url, window.location.origin); |
There was a problem hiding this comment.
This will not work in fastboot :/ There is no window object
There was a problem hiding this comment.
@GreatWizard Since we don't care about the host name here, I'd recommend using a dummy hostname.
let urlObj = new URL(url, 'https://example.com');| "ember-cli-babel": "6.16.0", | ||
| "ember-cli-cjs-transform": "1.3.0", | ||
| "jquery-param": "1.0.1", | ||
| "ember-url": "^0.6.0", |
There was a problem hiding this comment.
Please use strict version :) without ^ or only as ~`
|
@GreatWizard Good PR! There only seems to be a few minor things + a rebase to get this working. |
|
I'm sorry I have to recreate the PR because I delete all my forks on my account recently and I haven't see there is still an open PR onto ember-custom-actions... :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR is here to be able to used unamed action :)
And I take a look into buildUrl mixin to replace jquery-params by the native URL API.
There is a polyfills for old browser thanks to ember-url (because URL polyfills is not handle by babel).
What do you think?