Support for additional dotnet publish flags. #655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've got a logic error somewhere in here... working on it And fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many build scenarios and scripts require certain flags to succeed. For example
nuget restoremight be required prior to runningelectronize buildand support for the--no-restoreflag in the generated publish command is required.This PR adds the capability to add any of the dotnet publish flags to the
electronize buildcommand by appending the command with-- [--dotnet-publish-flag(s)]Backwards compatibility to keep current builds running is maintained by adding the
--self-containedflag if not present or overridden by--self-contained false|--no-self-contained. Additionally any other flags that are already built into the design of the command are ignored or stripped.