Add default HTML page for unconfigured domains #271
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the default server response for the nginx-proxy image to provide a more user-friendly error page when a domain is not configured, instead of returning a generic 503 error. The changes ensure that requests to unconfigured domains serve a custom HTML page with a clear message.
Default error page improvements:
default.htmlfile containing a styled message indicating the domain is not configured or disabled. (nginx-proxy/default.html)nginx.tmpltemplate to servedefault.htmlfor requests to unconfigured domains, replacing the previousreturn 503directive. (nginx-proxy/nginx.tmpl)listendirectives to usedefault_serverfor both HTTP and HTTPS, ensuring the default configuration is properly applied. (nginx-proxy/nginx.tmpl)Docker image adjustments:
Dockerfileto copy the newdefault.htmlinto the appropriate nginx HTML directory. (nginx-proxy/Dockerfile)