- 
                Notifications
    
You must be signed in to change notification settings  - Fork 44
 
Adding fix for ORAS5 #2422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Adding fix for ORAS5 #2422
Conversation
          Codecov ReportAttention: Patch coverage is  
 
 ❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@            Coverage Diff             @@
##             main    #2422      +/-   ##
==========================================
- Coverage   94.99%   93.81%   -1.18%     
==========================================
  Files         255      257       +2     
  Lines       14793    14979     +186     
==========================================
  Hits        14052    14052              
- Misses        741      927     +186     ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
  | 
    
| 
           Tried with the example recipe and it looks good, output seems as expected. Fast look through the code looks good. I'll do a more detailed review when I have more time.  | 
    
Description
Fix for ORAS5. It includes the option to make the 'irregular' (2d) grid 'unstructured' (1d) and UGRID-compliant. To do so, one needs to add the extra facet 'make_unstructured: true' and/or 'ugrid: true' in the recipe.
The mesh description ('horizontal_grid' in the recipe) needs to be read from a file (oras5_mesh.zip), which is based on a file that can be downloaded here. Since ORAS5 data is on the ORCA025 (Arakawa-C grid), there are different mesh files for tracers (T), and zonal/meridional velocities (u/v).
An example recipe for ORAS5 can be found here.
Some already downloaded data are stored here:
/work/bd1083/b380216/extraobsraw/Tier2/ORAS5/single_level
/work/bd1083/b380216/extraobsraw/Tier2/ORAS5/all_levels
/work/bd1083/b382555/extraobsraw/Tier2/ORAS5/all_levels
The grid files are also stored on Levante:
/work/bd0854/b382555/extraobsraw/Tier2/ORAS5/grids
Link to documentation: tba
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: