-
Notifications
You must be signed in to change notification settings - Fork 66
Add check for missing Zen4 installations #765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Instance
|
|
Instance
|
|
Instance
|
| echo "just run check_missing_installations.sh (should use easystacks/software.eessi.io/${{matrix.EESSI_VERSION}}/eessi-${{matrix.EESSI_VERSION}}-*.yml)" | ||
| for easystack_file in $(ls easystacks/software.eessi.io/${{matrix.EESSI_VERSION}}/eessi-${{matrix.EESSI_VERSION}}-eb-*.yml); do | ||
| if [ ${{matrix.EESSI_SOFTWARE_SUBDIR_OVERRIDE}} = "x86_64/amd/zen4" ]; then | ||
| if grep -q 2022b <<<"${easystack_file}"; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@laraPPr Makes sense, but let's add a comment to explain why we're doing this, both for 2022b and CUDA?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still confused, but that might be me. We're also not building CUDA stuff for e.g. haswell right now, but we don't have an explicit skip there, right? Why do we need it for zen4?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have the CUDA installations of CUDA-Samples and OSU-MicroBenchmarks installed for all CPU targets in the CPU-only path, but we don't want to do that going forward.
Those installations were split off into separate easystack files in #762 to make this possible.
Once we've made some more progress with the accel/nvidia part of the software layer, we'll likely remove those CUDA installations from the CPU path, they don't belong there.
boegel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
PR merged! Moved |
|
PR merged! Moved |
|
PR merged! Moved |
No description provided.