Fix Highway hook: change optarch in pre_prepare_hook and reset it in post_prepare_hook
#532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instance
|
boegel
requested changes
Apr 4, 2024
Contributor
boegel
left a comment
boegel
left a comment
There was a problem hiding this comment.
looks good, I would just add a comment to help ensure that the condition is kept in sync in the pre/post hooks used for Highway...
Co-authored-by: Kenneth Hoste <[email protected]>
Co-authored-by: Kenneth Hoste <[email protected]>
51 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the hook is changing a general build option (for setting
optarch=GENERIC), it has to be reset afterwards. See #529 (review).Tested it interactively for Haswell, Neoverse N1+V1. We could also let the bot do it, but then we'll need to add a rebuild easystack file.