always exclude '.wh.*' files when creating tarball in overlay #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
trz42
approved these changes
Jan 15, 2023
| if [ -d ${pilot_version}/software/${os}/${cpu_arch_subdir}/modules ]; then | ||
| # module files | ||
| find ${pilot_version}/software/${os}/${cpu_arch_subdir}/modules -type f >> ${files_list} | ||
| find ${pilot_version}/software/${os}/${cpu_arch_subdir}/modules -type f | grep -v '/\.wh\.' >> ${files_list} |
Collaborator
There was a problem hiding this comment.
Wonder if it would make sense to collect a list of files which have been filtered out and add that to the metadata when uploading the tarball? This would allow the human overseeing the ingestion procedure to double-check if anything had been removed that shouldn't.
Contributor
Author
There was a problem hiding this comment.
These .wh* files are temporary files created by fuse-overlayfs. Although we see them when compiling the list of files to include in the tarball, they're no longer there by the time we create the tarball.
Also, they're useless to us anyway...
trz42
pushed a commit
to trz42/software-layer
that referenced
this pull request
Jan 15, 2023
…nhancement/unified_script_to_access_EESSI Pulling in changes until PR EESSI#221.
trz42
pushed a commit
to trz42/software-layer
that referenced
this pull request
Jan 15, 2023
…nhancement/single_src_for_defaults Pulling in updates until PR EESSI#221.
trz42
pushed a commit
to trz42/software-layer
that referenced
this pull request
Jan 16, 2024
…y_structure moved easystack files to new directory structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for errors that pop up when creating the tarball because "whiteout" files are accidentally picked up, like:
(starting seeing this in some cases when using updated build container, cfr. #219)